Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding paths during BTR #146

Closed
wants to merge 1 commit into from
Closed

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented May 6, 2019

Type: feature

The following has been addressed in the PR:

Description:
This adds a paths array or the results of a paths function from any blocks run during BTR, after the script is completed. It waits for a returned promise to be resolved. @matt-gadd Is this along the lines of what you were thinking, or should these paths be discovered automatically somehow?
Resolves #134

@maier49 maier49 requested a review from matt-gadd May 6, 2019 23:34
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage    85.6%   85.64%   +0.04%     
==========================================
  Files          40       40              
  Lines        1723     1728       +5     
  Branches      430      432       +2     
==========================================
+ Hits         1475     1480       +5     
  Misses        248      248
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54051b...c6148a9. Read the comment docs.

@maier49 maier49 closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support adding to the pages to be visited in build time render during build time render
1 participant