Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the fetch shim does not work in BTR's jsdom renderer when not building legacy #316

Open
agubler opened this issue Jan 4, 2021 · 0 comments

Comments

@agubler
Copy link
Member

agubler commented Jan 4, 2021

Bug

Dojo's fetch shim does not work with modern (the default setting) builds when using the jsdom renderer in BTR. Current in the modern setting fetch is statically set to "true" but this is not the case in a jsdom environment. As we do not want to do anything different build wise just for BTR we should consider allowing fetch to behave like the other browser api shim's such as intersection observer. This is to actually allow the sniff at runtime and load and register the shim if the environment requires. The fetch shim is a separate bundle already so this would not increase the amount of js loaded/parsed for an application unless the user environment did not have fetch (which is none of the modern browsers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant