Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTR does not elide localhost outside the mount point #327

Open
msssk opened this issue May 5, 2021 · 0 comments
Open

BTR does not elide localhost outside the mount point #327

msssk opened this issue May 5, 2021 · 0 comments

Comments

@msssk
Copy link

msssk commented May 5, 2021

Bug

webpack-contrib/src/build-time-render/BuildTimeRender.ts

Line 393 in 3641d4a

content = content.replace(/http:\/\/localhost:\d+\//g, '');

BTR elides localhost from URLs, but this process is not applied to the document head.

Code

const image = require('./image.jpg');

// in widget
return (
    <div>
        <head>
            <meta property="og:image" content={image} />
        </head>
    </div>
);

Expected behavior:

<meta property="og:image" content="image.jpg" />

Actual behavior:

<meta property="og:image" content="http://localhost:54327/image.jpg" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msssk