Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisArgument of new Promise resolver can be more useful #97

Closed
smcmurray opened this issue Feb 28, 2014 · 2 comments
Closed

thisArgument of new Promise resolver can be more useful #97

smcmurray opened this issue Feb 28, 2014 · 2 comments
Labels

Comments

@smcmurray
Copy link

The resolver spec at line 13 mandates that the resolver has to be called with the thisArgument undefined.

Would it be more useful to set the thisArgument to promise?

@juandopazo
Copy link

We've discussed this in promises-aplus/constructor-spec#23, and I think the consensus was to keep it undefined for consistency with then.

@domenic
Copy link
Owner

domenic commented Feb 28, 2014

Hi @smcmurray! This spec is finalized, and no further API changes will be made to it beyond those necessary to align with the January TC39 consensus. Since the APIs are already shipping in browsers, we couldn't really make such changes even if we tried. So thanks for your interest, but we won't be able to do anything about it.

Anyway, the issue is that the resolver argument is not a method, but instead a function, and as such it should be called as a function, and not invoked as a method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants