Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button on / off #7

Open
ad-m opened this issue Jul 25, 2015 · 3 comments
Open

Edit button on / off #7

ad-m opened this issue Jul 25, 2015 · 3 comments

Comments

@ad-m
Copy link
Contributor

ad-m commented Jul 25, 2015

Hello,

I am would like report that django-tinycontent break design of my page in results of auto add link to edit page eg. sidebar. It is completely unacceptable.

I am have 2 solution for that.

  1. Use django-constance for extra dynamic settings, overwrite theme and provide "edit-mode" for administrator.
  2. Extend django-constance model to provide radio field "hide edit button". Then new fields display edit button, but I can hide it.

What do you prefer?

Greetings,
Adam

@ad-m ad-m changed the title Hello, Edit button on / off Jul 25, 2015
@dominicrodger
Copy link
Owner

I'd prefer to avoid adding a dependency on django-constance.

Two alternatives to your suggestions:

  1. Override the templates in your project.
  2. Have a setting in settings.py for removing the add/edit links.

Dom

@ad-m
Copy link
Contributor Author

ad-m commented Jul 26, 2015

Overwrite a templates sounds nice.

I will provide new package django-tinycontent-constance with build-in
templates for constance support soon.

Wysłano z urządzenia mobilnego.
26 lip 2015 8:56 PM "Dominic Rodger" [email protected] napisał(a):

I'd prefer to avoid adding a dependency on django-constance.

Two alternatives to your suggestions:

  1. Override the templates in your project.
  2. Have a setting in settings.py for removing the add/edit links.

Dom


Reply to this email directly or view it on GitHub
#7 (comment)
.

@ad-m
Copy link
Contributor Author

ad-m commented Jul 27, 2015

We can drop django-constance by store in session settings "change". By settings.py we will select default settings (show / not), next to by views settings will be updated.

ad-m added a commit to watchdogpolska/django-tinycontent that referenced this issue Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants