Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gain compatibility with Node 20.x and higher #1145

Open
dondi opened this issue Nov 13, 2024 · 2 comments
Open

Gain compatibility with Node 20.x and higher #1145

dondi opened this issue Nov 13, 2024 · 2 comments

Comments

@dondi
Copy link
Owner

dondi commented Nov 13, 2024

Per @akaiap in #1118, our current code relies on a canvas library that stops compatibility at Node 18.x. We want to broaden our compatibility to newer versions

@akaiap
Copy link
Collaborator

akaiap commented Nov 20, 2024

Very straight forward regading the solution

  1. Update the canvas package in the {} package.json file to latest version
  2. npm install
  3. Check for Breaking Changes
  • Review for any breaking changes and update for API changes
  1. Update GitHub Actions Workflow to include 20.x in the test matrix

*if there are depreciation issues I will run npm update and npm audit to identify and fix vulnerabilities.

  1. Test

@akaiap
Copy link
Collaborator

akaiap commented Nov 29, 2024

Sucess!

  • Surprisingly, within {}package.json there was not a canvas dependency. Meaning it was a transitive dependency instead of direct.
  • canvas is being installed as a peer-dependcy and not compatible for node 20.x (dependent on canvg 2.0.0)
  1. Updated the package to "canvg": "^3.1.1"
  2. npm install
  3. Then I added the latest version of canvas canvas@^2.11.2
  4. updated github actions workflow to include 20.x and 22.x

Finally, I verified the workflow passed the checks!

dondi added a commit that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants