Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include npm lint in GitHub Action CI script #1147

Open
dondi opened this issue Nov 13, 2024 · 1 comment
Open

Include npm lint in GitHub Action CI script #1147

dondi opened this issue Nov 13, 2024 · 1 comment

Comments

@dondi
Copy link
Owner

dondi commented Nov 13, 2024

In addition to running the test suite, running our lint checker will help us catch formatting issues on an on-going basis

@akaiap
Copy link
Collaborator

akaiap commented Nov 20, 2024

  • Created a pull request with the new command npm lint
  • Succesfuly pushed the commit and was able to see the build in GitHub Actions.
  • Test failed! (meaning npm lint worked) due to formatting issues
  • The job failed due to two errors in the setup-handlers.js file:
  1. Line 117: Trailing spaces are not allowed.
  2. Line 137: Missing semicolon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants