Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rate as a configuration option for Graph- and GenericRandomError plugins #971

Open
4 tasks
waldekmastykarz opened this issue Jan 31, 2025 · 2 comments
Open
4 tasks

Move rate as a configuration option for Graph- and GenericRandomError plugins #971

waldekmastykarz opened this issue Jan 31, 2025 · 2 comments
Assignees
@waldekmastykarz

Comments

@waldekmastykarz
Copy link
Collaborator

waldekmastykarz commented Jan 31, 2025 •
edited
Loading

When we built Dev Proxy, we exposed Rate as a top-level configuration option. In reality, it applies only to the Graph- and GenericRandomError plugins. As such, we should move it to these plugins and remove it from top-level config. This will more clearly depict its scope and avoid confusion.

  • Update code
  • Update config
  • Update presets in the gallery
  • Update docs
@waldekmastykarz
Copy link
Collaborator Author

Thoughts @garrytrinder?

@waldekmastykarz waldekmastykarz added enhancement New feature or request needs peer review Issue needs review from other team members breaking change labels Jan 31, 2025
@garrytrinder
Copy link
Contributor

Agreed, good idea 👍

@waldekmastykarz waldekmastykarz removed the needs peer review Issue needs review from other team members label Jan 31, 2025
@waldekmastykarz waldekmastykarz self-assigned this Feb 12, 2025
@waldekmastykarz waldekmastykarz removed enhancement New feature or request breaking change labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waldekmastykarz waldekmastykarz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waldekmastykarz @garrytrinder