Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Cache Mode envvar #423

Closed
mynameisfiber opened this issue Apr 6, 2024 · 3 comments · Fixed by #424
Closed

Typo in Cache Mode envvar #423

mynameisfiber opened this issue Apr 6, 2024 · 3 comments · Fixed by #424

Comments

@mynameisfiber
Copy link
Contributor

The cache mode envvar is CLOUPATHLIB_FILE_CACHE_MODE while it should be CLOUDPATHLIB_FILE_CACHE_MODE.

This is consistent across the project, however is definitely unexpected from a user perspective.
@pjbull
Copy link
Member

pjbull commented Apr 6, 2024

😆 that is annoying and unexpected!

We'd accept a fix that:
(1) reads both for the time being, since some people may have copy-pasted.
(2) emits a deprecation warning if the typo'd CLOUPATHLIB_FILE_CACHE_MODE is used
(2) updates docs and everything else to the correct env var so people use that going forward

@mynameisfiber
Copy link
Contributor Author

I'll send a PR in the coming days!

@mynameisfiber mynameisfiber mentioned this issue Apr 8, 2024
Merged
10 tasks
@jayqi
Copy link
Member

jayqi commented Apr 9, 2024

Closed by #424 / #426. New issue #425 captures removal of the deprecated typoed environment variable.

@jayqi jayqi closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes typo in Caching envvar mynameisfiber/cloudpathlib
3 participants
@mynameisfiber @pjbull @jayqi