Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content nodes] Rationalize the use of timestamp-relative columns in data_sources_nodes #9966

Open
aubin-tchoi opened this issue Jan 14, 2025 · 3 comments
Assignees

Comments

@aubin-tchoi
Copy link
Contributor

  • Follows up on #9849 and this thread.
  • We have a column timestamp in data_sources_documents and data_sources_nodes that is currently filled by connectors with lastUpdatedAt and filled by other users of api/v1 by whatever.
  • We need the lastUpdatedAt information to fill the content nodes.
  • We currently use the timestamp column to fill this lastUpdatedAt in front.
  • Depending on what we observe about what the users do, we need to update the name of the column.
@aubin-tchoi
Copy link
Contributor Author

Pending because we need to observe the logs regarding what the users of /api/v1 do.

@philipperolet
Copy link
Contributor

Thanks for creating the card 🙏 Plan would be to:

  • look at logs of this after a week;
  • hope we don't have any user-set timestamp, if not rename bluntly
  • if we do, warn related users, deprecate the field (so leave it working but mark as deprecated in favor of a lastUpsertedAt field)

@philipperolet
Copy link
Contributor

Moving to eng runner and assigning us @aubin-tchoi , not necessary for the ship + needs some waiting so we can't act now anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants