Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show data when predict is not "response" #313

Closed
DominiqueMakowski opened this issue Jan 10, 2025 · 1 comment · Fixed by #353
Closed

Don't show data when predict is not "response" #313

DominiqueMakowski opened this issue Jan 10, 2025 · 1 comment · Fixed by #353
Assignees
@strengejacke
Labels
Plot 🎇 Something related to plotting

Comments

@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Jan 10, 2025 •
edited
Loading

Add something like

if(!attributes(x)$predict %in% c("response", "expectation")) {
  show_data <- FALSE
}
@strengejacke strengejacke added the Plot 🎇 Something related to plotting label Jan 10, 2025
@strengejacke strengejacke mentioned this issue Jan 10, 2025
Open
@strengejacke
Copy link
Member

I would even default to show_data = FALSE. In our field, we have datasets with > 1k up to 150k observations, and data points don't make much sense then, plus the plot rendering is much longer.

@strengejacke strengejacke self-assigned this Jan 18, 2025
strengejacke added a commit that referenced this issue Jan 18, 2025
@strengejacke
Don't show data when predict is not "response"
37606c1 
Fixes #313
@strengejacke strengejacke mentioned this issue Jan 18, 2025
Merged
strengejacke added a commit that referenced this issue Jan 18, 2025
@strengejacke
Don't show data when predict is not "response" (#353)
5d2b8a2 
* Don't show data when predict is not "response"
Fixes #313

* title

* title

* docs

* docs

* styler, spelling

* add backend argument

* random test order?

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strengejacke strengejacke

Labels
Plot 🎇 Something related to plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show data when predict is not "response" easystats/modelbased
2 participants
@DominiqueMakowski @strengejacke