Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split plot into facets when predictions for all single terms are requested #316

Open
strengejacke opened this issue Jan 10, 2025 · 5 comments
Labels
Feature idea 🔥 New feature or request Plot 🎇 Something related to plotting

Comments

@strengejacke
Copy link
Member

strengejacke commented Jan 10, 2025

This plot looks a bit strange, I think it makes more sense, at least to have an option to split into facets.

library(modelbased)
fit <- lm(mpg ~ cyl + disp + gear, data = mtcars)

result <- estimate_relation(fit)
plot(result)

Created on 2025-01-10 with reprex v2.1.1

@strengejacke strengejacke added Feature idea 🔥 New feature or request Plot 🎇 Something related to plotting labels Jan 10, 2025
@DominiqueMakowski
Copy link
Member

it does look meg, but then why would you by all 3 predictors at the same time if there's no interaction... I don't think it's something people would meaningfully use in real life

@bwiernik
Copy link
Contributor

Do we want to default to just plotting the first predictor unless the user explicitly asks for 2 or 3?

@DominiqueMakowski
Copy link
Member

plotting what is in estimate_relation() is okay I think, it's just that in this case people should estimate_relation(by="cyl") only (for instance) in the first place, as having the combination of all the factors is useless

@strengejacke
Copy link
Member Author

it does look meg, but then why would you by all 3 predictors at the same time if there's no interaction... I don't think it's something people would meaningfully use in real life

Agree, but I think this was one of the examples taken from the docs or vignettes

@DominiqueMakowski
Copy link
Member

I'll be going through the vignettes now and will do some spring cleaning :) we'll see what needs to be adjusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature idea 🔥 New feature or request Plot 🎇 Something related to plotting
Projects
None yet
Development

No branches or pull requests

3 participants