Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulk. BulkUpdate. CollectErrors did not print the error log #37

Open
liuyinyin opened this issue Jul 1, 2019 · 2 comments
Open

bulk. BulkUpdate. CollectErrors did not print the error log #37

liuyinyin opened this issue Jul 1, 2019 · 2 comments

Comments

@liuyinyin
Copy link
Contributor

When using Docstore. IndexAll (Class), IO. Ebeanservice. Elastic. Bulk. BulkUpdate. CollectErrors did not print the error log, want to add a listener, when there is an error to see what had happened.
I changed the code in my project, added listeners, and saw exactly what went wrong.
@rbygrave
Copy link
Member

rbygrave commented Jul 1, 2019

Right.

Do you want to submit a PR showing the API changes you'd like with the listeners?

Additionally or alternatively it looks like BulkUpdate.flush() should return the collected errors ... which would be a List<Map<String,Object>> but we should probably wrap that in a new BulkResponse type object.

@liuyinyin
Copy link
Contributor Author

I'm going to submit a PR recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbygrave @liuyinyin