Handles the TypePattern DOM API modifications in the JDT.UI #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noopur2507
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Multiple changes are required.
- Some code changes need simplification
- Some changes will cause a CCE
- Some changes are unnecessary
I will create a new PR to fix #1994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In the JDT Core DOM, the TypePattern APIs have been modified to handle unnamed variables and patterns, as expected to be implemented through eclipse-jdt/eclipse.jdt.core#3635. Therefore, appropriate changes need to be made in JDT UI as well.
This PR closes #1994
How to test
Author checklist