Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up testing work from the addition of installation flavors #6631

Open
cmacknz opened this issue Jan 29, 2025 · 3 comments
Open

Follow up testing work from the addition of installation flavors #6631

cmacknz opened this issue Jan 29, 2025 · 3 comments
Assignees
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@cmacknz
Copy link
Member

cmacknz commented Jan 29, 2025

Follow up testing work from #6542

Upgrades for agents with an installed flavor

  • Install an agent with the default, basic flavor and upgrade it to another version that supports flavors. After the upgrade none of the binaries from the servers flavor should be on disk.
  • Install an agent with the servers flavor and upgrade to another version that supports flavors. After the upgrade all of the binaries from the servers flavor should be on disk.

Integration test for components with additional file dependencies

  • Ensure the component_files lists of osquerybeat, apm-server, endpoint-security, and cloudbeat are correctly preserved for the appropriate flavors. Ideally, confirm the integration can be installed and remain healthy as a basic sanity check.
    • endpoint-security is already covered by an integration test but the others are not.
    • Perhaps this would be best be done by extending the existing installation tests to look at what their spec files declare and ensure the files are preserved.
      t.Run("check components set",
      testComponentsPresence(ctx, fixture,
      []componentPresenceDefinition{
      {"agentbeat", []string{"windows", "linux", "darwin"}},
      {"endpoint-security", []string{"windows", "linux", "darwin"}},
      {"pf-host-agent", []string{"linux"}},
      },
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Jan 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz cmacknz added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team and removed Team:Elastic-Agent Label for the Agent team labels Jan 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@michalpristas
Copy link
Contributor

note: checking for files defined in spec file is not an option, component files is a filter and does not require files to be present. e.g some files present only on linux, exe paths only on windows. this information is not part of the filter definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

3 participants