From 67bcda02d9adf5adc8560b748167087b72931a0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tjitse=20Efd=C3=A9?= Date: Fri, 31 Jan 2025 10:22:33 +0100 Subject: [PATCH 1/2] Add RUM prefix to tracking id --- src/ViewModel/Rumvision.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ViewModel/Rumvision.php b/src/ViewModel/Rumvision.php index 0df2ccf..49c9805 100644 --- a/src/ViewModel/Rumvision.php +++ b/src/ViewModel/Rumvision.php @@ -27,8 +27,8 @@ public function shouldIncludeScript(): bool public function getTrackingId() :string { - return $this->configuration - ->getTrackingId(); + $trackingId = $this->configuration->getTrackingId(); + return str_starts_with($trackingId, 'RUM-') ? $trackingId : sprintf('RUM-%s', $trackingId); } public function getHostName() :string From 8d7f41c2a3064941f1f44032204f817cc64c6f3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tjitse=20Efd=C3=A9?= Date: Fri, 31 Jan 2025 10:37:46 +0100 Subject: [PATCH 2/2] Revert hardcoding RUM- in tracking phtml --- src/view/frontend/templates/script/rumvision.phtml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/frontend/templates/script/rumvision.phtml b/src/view/frontend/templates/script/rumvision.phtml index c910f97..ff59530 100755 --- a/src/view/frontend/templates/script/rumvision.phtml +++ b/src/view/frontend/templates/script/rumvision.phtml @@ -21,10 +21,10 @@ if (! $viewModel->shouldIncludeScript()) { if ( s.urls && s.regex && ( s.page = eval('('+s.regex+')')( s.urls, vi.location.pathname ) ) && !s.page.type ) { return sessionStorage.setItem('rumv', JSON.stringify( s ) ); } - + vi.rumv.storage = s; var head = si.querySelector('head'), js = si.createElement('script'); js.src = 'https://d5yoctgpv4cpx.cloudfront.net/'+rum+'/v4-'+vi.location.hostname+'.js'; head.appendChild(js); - })( 'RUM-escapeJs($viewModel->getTrackingId()) ?>', window, document, 'escapeJs($viewModel->getHostName()) ?>' ); + })( 'escapeJs($viewModel->getTrackingId()) ?>', window, document, 'escapeJs($viewModel->getHostName()) ?>' );