circe-color-nicks, circe-highlight-all-nicks: Combine and generalize?

[jorgenschaefer]

retroj mentioned that the modules circe-color-nicksand circe-highlight-all-nicks have very similar functionality and likely should be merged into a single module.

As a bug, in circe-color-nicks the functions to enable/disable the module are written as if lui-pre-output-hook was buffer-local. It isn't.

[jorgenschaefer]

lui-highlight-keywords could support the format (function1 function2) so that function1 is called once to generate a regular expression (e.g. "all nicks in this channel"), and function2 is called for every match (so it can highlight that match in whatever way it pleases). Would this be generalized enough an implementation in lui?

(function1 should actually also be able to be a list of strings which are combined using regexp-opt, or a hash table in which case its keys are combined using regexp-opt; this allows to just use circe-channel-users as the first element of the list.)

[jorgenschaefer]

Any volunteer to work on this?

[twopir]

I could give it a try.

[jorgenschaefer]

Go ahead :-) And thank you!

[jorgenschaefer]

When working on this, looking at #54 would be good, too.

[jorgenschaefer]

Out of curiosity, does anyone actually use highlight-all-nicks.el?

[wasamasa]

Yes. Most results come from people chucking in their packages into their emacs configurations, however I've found four persons using it.

[jorgenschaefer]

Scary. :-D