Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typescript-mode compatible with mmm-mode #128

Closed
Jevri opened this issue Feb 28, 2020 · 6 comments
Closed

Make typescript-mode compatible with mmm-mode #128

Jevri opened this issue Feb 28, 2020 · 6 comments

Comments

@Jevri
Copy link
Contributor

Jevri commented Feb 28, 2020

The functions conserned with parsing call widen. This makes makes it unable to parse properly when used with mmm-mode.

@lddubeau
Copy link
Collaborator

In principle, being able to work fine with mmm-mode would be a valuable feature.

So we need someone who knows mmm-mode well enough to step up and implement this change. (And that person is not me because I do not use mmm-mode.) Merely removing the calls to widen won't do it. This email mentions documentation for major modes to follow to work well with mmm-mode.

@lddubeau lddubeau changed the title The functions conserned with parsing calls widen Make typescript-mode compatible with mmm-mode Feb 28, 2020
@lddubeau
Copy link
Collaborator

I've moved your title into the first comment and edited the title to reflect better what the stakes are. Dealing with widen is probably just one aspect of compatibility with mmm-mode.

@josteink
Copy link
Member

So we need someone who knows mmm-mode well enough to step up and implement this change

Agreed. And it's not me either.

How about you, @Jevri ?

@Jevri
Copy link
Contributor Author

Jevri commented Feb 28, 2020

I honestly do not know much about either, other then it did not work because typescript mode tried to parse everything

@Jevri
Copy link
Contributor Author

Jevri commented Feb 28, 2020

I might investigate a bit though

@Jevri
Copy link
Contributor Author

Jevri commented Aug 24, 2020

I think this was actually a bug in Vue mode. The solution in the comments here fixed my issue. Sorry for the trouble :)

@Jevri Jevri closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants