Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tauri-yew Migration #47

Closed
emanuele-em opened this issue Mar 22, 2023 · 7 comments
Closed

Tauri-yew Migration #47

emanuele-em opened this issue Mar 22, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@emanuele-em
Copy link
Owner

@sak96 please use tauri-yew-migration branch

@emanuele-em emanuele-em added the enhancement New feature or request label Mar 22, 2023
@emanuele-em emanuele-em self-assigned this Mar 22, 2023
@sak96
Copy link
Contributor

sak96 commented Mar 25, 2023

#24 might be fixed with this.

@sak96
Copy link
Contributor

sak96 commented Mar 26, 2023

@emanuele-em i think almost all features are done after merging #53. let me know if something is missing.

  • Some Refactoring might be required for correct placement of components.
  • Some of the clone of request can be avoided completely by using std::rc::Rc as they are not mutated only borrowed not mutated
  • Add yewdux or other library to store state in local storage.
  • Add yew_router to have separate pages for separate views.

The instruction to run app is mentioned here

@emanuele-em
Copy link
Owner Author

yes thank you for your awesome work, today I proceed with some refactor on tauri-ui branch and for minor fixes, good job @sak96

@sak96
Copy link
Contributor

sak96 commented Mar 26, 2023

i see i missed mentioning trunk :( in contrib.md

@sak96
Copy link
Contributor

sak96 commented Apr 14, 2023

The UI now looks very good.
awesome stuff: @emanuele-em

I see you are trying to fix rust.yml
may be you can use for releasing binaries

https://github.com/actions/create-release

@emanuele-em
Copy link
Owner Author

emanuele-em commented Apr 14, 2023

@sak96 yes I'm trying to fix clippy that works on my machine but not on github, if you are more expert about it please tell me a suggestion, I'm going crazy

@sak96
Copy link
Contributor

sak96 commented Apr 14, 2023

can you run

rustup update

OR

rustup component add clippy

OR

checkout this
That will update clippy to latest version.
cc: @emanuele-em

let me know if this help also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants