Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support overlay for errors and warnings #153

Open
gabrielcsapo opened this issue Oct 8, 2020 · 3 comments
Open

[feature] support overlay for errors and warnings #153

gabrielcsapo opened this issue Oct 8, 2020 · 3 comments

Comments

@gabrielcsapo
Copy link

gabrielcsapo commented Oct 8, 2020

This feature would be similar to https://webpack.js.org/configuration/dev-server/#devserveroverlay and would look like the following.

Screen Shot 2020-10-08 at 1 00 14 AM

Instead of having to monitor the console for errors it would be great to throw an overlay up and alert the developer that something has gone wrong. We have all of this information available and it should just require styling it to show up when the developer has configured it.

@rwjblue
Copy link
Member

rwjblue commented Oct 8, 2020

Hmm, sorry but I don't see how this is related to live reload. What am I missing here?

@gabrielcsapo
Copy link
Author

@rwjblue When there is a failure in the build, live reload will not load the page. I am suggesting that live reload show the error in the context of the application so that it:

A. Provides a larger canvas to display the stack trace
B. Doesn't require switching contexts if the developer is only looking at their editor and the browser

@gabrielcsapo
Copy link
Author

@rwjblue does this seem like the right place for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants