Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency lint #52

Open
ryanto opened this issue Sep 11, 2018 · 1 comment
Open

Add dependency lint #52

ryanto opened this issue Sep 11, 2018 · 1 comment

Comments

@ryanto
Copy link
Member

ryanto commented Sep 11, 2018

We need to be sure we're getting the right dependency versions on travis. We've solved this problem in other projects with dependency lint.

@ryanto ryanto added the Bug label Sep 11, 2018
@ryanto
Copy link
Member Author

ryanto commented Sep 18, 2018

I took a shot at this earlier and it looks like were still getting conflicts around ember data. The build has the right version, but dependency-lint notices two data versions between addon docs and storefront. So I'm misunderstanding something here.

 ~/p/ember-data-storefront $ ember dependency-lint

ember-data
Allowed: (any single version)
Found: 3.4.0, 3.1.1
ember-data-storefront
├── [email protected]
└─┬ ember-cli-addon-docs
  └── [email protected]

I'm unsure how to resolve this. I commented on a discuss thread about a similar issue. My guess is ember-try + yarn resolutions, but I'm not sure.

I'm blocked on this until I can understand what's going on a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant