Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success icon missing #349

Closed
RiodeJaneiroo opened this issue Feb 23, 2024 · 4 comments
Closed

Success icon missing #349

RiodeJaneiroo opened this issue Feb 23, 2024 · 4 comments

Comments

@RiodeJaneiroo
Copy link

Describe the feature / bug 📝:

When using toast.promise, the success icon is not displayed after the promise resolves. This behavior persists across different environments, including on the official documentation site.

Steps to reproduce the bug 🔁:

it also do not display on sonner site)
Codesandbox

@combdn
Copy link

combdn commented Feb 23, 2024

I'm unsure if it's related or a separate issue, but if I define my own icons, the spinner is never replaced by the success icon.

success-spinner.mp4

@RiodeJaneiroo
Copy link
Author

RiodeJaneiroo commented Feb 23, 2024

Screenshot 2024-02-23 at 21 42 05

undefined in style, another bug. undefinedpx

@emilkowalski
Copy link
Owner

Fixed all bugs reported here in #352

@combdn
Copy link

combdn commented Mar 13, 2024

In 1.4.2, my spinner is showing next to the success icon:

CleanShot.2024-03-13.at.14.10.30.mp4

Icons configuration:

{
  success: <BsCheckCircleFill />,
  info: <BsInfoCircleFill />,
  warning: <BsExclamationTriangleFill />,
  error: <BsExclamationOctagonFill />,
  loading: <Spinner />,
}

If I remove my spinner icon, it works correctly (shows the spinner, then the spinner is replaced by the success icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants