Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no logs decoding #3

Open
Evan-Kim2028 opened this issue Jul 2, 2024 · 3 comments
Open

no logs decoding #3

Evan-Kim2028 opened this issue Jul 2, 2024 · 3 comments

Comments

@Evan-Kim2028
Copy link

There doesn't appear to be any logs decoding functionality in the hypersync go client. Would be nice to have feature parity with the python go client, which does have decoding logs ability:

https://github.com/enviodev/hypersync-client-python/blob/9bb040e7a954f919d3af24b0c9e1617351091bd8/src/lib.rs#L12

@0x19
Copy link
Collaborator

0x19 commented Jul 11, 2024

I was thinking about this, to potentially hold mdbx database for logs or just interface that is going to allow you to pass your own signatures/abi for functions and logs decoding.

Challenge here with automatic decoding on a large scale is that it takes time to decode, which will for sure slow down the system. Mdbx is fast tho so it won't be as much but on millions of rows it might take system resources that needs to be taken under consideration. Additionally, not big but disk space as well. For lets say, complete ETH, probably in range of few, up to 10-15GB of disk space.

Anyway, I went all around, just wanted to give thoughts here about what I had in mind.

@0x19
Copy link
Collaborator

0x19 commented Jul 11, 2024

In some cases, contract used for logs can be proxy, decoding it requires knowledge of the latest proxied contract in order to efficiently decode log.

@0x19
Copy link
Collaborator

0x19 commented Sep 18, 2024

@Evan-Kim2028 Added new #6 PR that will be dealing with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants