Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with multiple {{loginButtons}} on page #12

Open
mcrider opened this issue Jul 4, 2013 · 2 comments
Open

Issues with multiple {{loginButtons}} on page #12

mcrider opened this issue Jul 4, 2013 · 2 comments

Comments

@mcrider
Copy link

mcrider commented Jul 4, 2013

I use {{loginButtons}} twice in my app, the second call being displayed only if the user is on a mobile device. Doing this causes logging in/signing up to break assumedly because of some of the global DOM calls are using the second (unused) login form as a form source.

My current hack is to remove the invisible {{loginButtons}} from the DOM on page load, but it might be be a good idea to scope the DOM calls in this package to the active form.

Thanks for your work on this package!

@erobit
Copy link
Owner

erobit commented Aug 20, 2013

Ah yes, a major refactor is needed in order to make the events scoped to their parent DOM forms. I'll definitely keep this open as an enhancement.

@jamesdwilson
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants