Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for getMasterRequest() #164

Closed
DiegoPino opened this issue May 23, 2023 · 2 comments
Closed

Remove check for getMasterRequest() #164

DiegoPino opened this issue May 23, 2023 · 2 comments
Assignees
@DiegoPino
Labels
External Bug It is not my fault (anonymous Geologist) Release duty Things only a mad person should do Reporting Errors, Logs, etc. VBO Actions I got my head out the sunroof
Milestone
0.5.0

Comments

@DiegoPino
Copy link
Member

Since Drupal 9.4 (and there is a deprecation notice in 9.3) Drupal has moved into a Service Wrapper for the Symphony HTTP libraries. Funny is that getMainRequest() is only present in Symfony 5+ (and 6) but Drupal core 9.5.x only support Symfony 4. Yet another Drupal priority that is not a priroity. So I will check directly on our Facet Processor if the Service (not the base class, means the shim ) has getMainRequest() giving people with Drupal 9.3 (no one should be there but I like allowing older systems to run) a chance.
@DiegoPino DiegoPino self-assigned this May 23, 2023
@DiegoPino DiegoPino added Reporting Errors, Logs, etc. External Bug It is not my fault (anonymous Geologist) Release duty Things only a mad person should do VBO Actions I got my head out the sunroof labels May 23, 2023
@DiegoPino DiegoPino added this to the 0.5.0 milestone May 23, 2023
@DiegoPino
Copy link
Member Author

PS: this is the last 0.5.0, I will roll a release and move to 0.6.0

@DiegoPino DiegoPino mentioned this issue May 27, 2023
Merged
@DiegoPino
Copy link
Member Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
External Bug It is not my fault (anonymous Geologist) Release duty Things only a mad person should do Reporting Errors, Logs, etc. VBO Actions I got my head out the sunroof
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@DiegoPino