Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice for Update Modes so people become aware that a template driven update Might generate more keys #170

Closed
DiegoPino opened this issue Jun 14, 2023 · 2 comments
Closed

Add notice for Update Modes so people become aware that a template driven update Might generate more keys #170

DiegoPino opened this issue Jun 14, 2023 · 2 comments
Assignees
@DiegoPino
Labels
CSV Processing Things we do here and there to keep the tabulated goddesses happy enhancement New feature or request UI Buttons and pixels
Milestone
0.8.0

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Jun 14, 2023 •
edited
Loading

What?

This has happened too many times: We do an replace update, but mapping to a twig template. The CSV has only the keys we want to replace but because all is mediated by a template the template itself generates new empty keys that end replacing good metadata we don't want.

A simple extra (IN BOLD) notice for the two replacement modes warning people about that, will (hopefully) make everyone think twice before applying a template blindly! And save many revisions to us/everyone.
@DiegoPino DiegoPino self-assigned this Jun 14, 2023
@DiegoPino DiegoPino added enhancement New feature or request UI Buttons and pixels CSV Processing Things we do here and there to keep the tabulated goddesses happy labels Jun 14, 2023
@DiegoPino DiegoPino added this to the 0.5.0 milestone Jun 14, 2023
@alliomeria
Copy link
Contributor

Somewhat helped by #204...

@DiegoPino DiegoPino modified the milestones: 0.5.0, 0.8.0 Jun 26, 2024
@DiegoPino
Copy link
Member Author

Fixed via 427f09b by @alliomeria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
CSV Processing Things we do here and there to keep the tabulated goddesses happy enhancement New feature or request UI Buttons and pixels
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@DiegoPino @alliomeria