Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Preview AMI set for Add Metadata Display #180

Closed
aksm opened this issue Aug 3, 2023 · 6 comments
Closed

Metadata Preview AMI set for Add Metadata Display #180

aksm opened this issue Aug 3, 2023 · 6 comments

Comments

@aksm
Copy link
Contributor

aksm commented Aug 3, 2023

What?

Currently, checking an AMI set via Metadata Display Preview requires editing an already saved Metadata Display template. When adding a new template the option for AMI Sets is not available.

It looks like all that's required is to change the following:

ami/ami.module

Line 36 in bceee5d

function ami_form_metadatadisplay_entity_edit_form_alter(&$form,FormStateInterface $form_state, $form_id) {

to:

function ami_form_metadatadisplay_entity_form_alter(&$form,FormStateInterface $form_state, $form_id)
@DiegoPino
Copy link
Member

@aksm means adding extra, or just changing? Thanks for catching this one!

@aksm
Copy link
Contributor Author

aksm commented Aug 3, 2023

@aksm means adding extra, or just changing? Thanks for catching this one!

@DiegoPino Just changing. The base form hook covers both.

@DiegoPino
Copy link
Member

Ok, but the delete one will have a preview then? mmmmm so maybe it needs internal a check of which form is using it?

@aksm
Copy link
Contributor Author

aksm commented Aug 3, 2023

Ok, but the delete one will have a preview then? mmmmm so maybe it needs internal a check of which form is using it?

@DiegoPino Just checked and the delete form isn't altered by the base form hook.

@DiegoPino
Copy link
Member

ok, cool. thx!

@aksm aksm removed their assignment Sep 29, 2023
@DiegoPino
Copy link
Member

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants