Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure ap:tasks are not overridden by our standardized defaults when updating via an AMI update via replace operation #200

Closed
DiegoPino opened this issue May 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working queue workers Ones taking the FI and doing the FO
Milestone

Comments

@DiegoPino
Copy link
Member

what?

The moment in time, when we check/set the basic required ap:taskjson fields during an AMI Set Update operation is too soon for a "replace" operation. Most replace operations won't have that key at all defined and because we check if they need to be "normalized" on the output of a direct/replace action before we merge back to the whole ADO, we end removing manually set nested keys/values, like the one that allows another label key to be used for node title or even the "not run this SBR processor"

@alliomeria this is what you correctly diagnosed today. Thanks for debugging that. I will fix this. Sorry for the hiccup

@DiegoPino DiegoPino added bug Something isn't working queue workers Ones taking the FI and doing the FO labels May 10, 2024
@DiegoPino DiegoPino added this to the 0.8.0 milestone May 10, 2024
@DiegoPino DiegoPino self-assigned this May 10, 2024
@alliomeria
Copy link
Contributor

alliomeria commented May 10, 2024

Thank you for reviewing this together with me live today, and confirming the current setup @DiegoPino! Thank you also for making this issue and adjusting where the ap:tasks are being checked + set. :)

DiegoPino added a commit that referenced this issue May 10, 2024
See #200 or #200

Note. I think we should also on replace/append and even on full replace log the JSON diff the way we do via VBO replace. @alliomeria thoughts?
@DiegoPino
Copy link
Member Author

Resolved via 0dda14a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working queue workers Ones taking the FI and doing the FO
Projects
None yet
Development

No branches or pull requests

2 participants