Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both generated scripts (build.sh and flash.sh) won't work when running template on Windows and using Dev Containers/WSL #141

Open
MihaMarkic opened this issue Jul 23, 2023 · 1 comment

Comments

@MihaMarkic
Copy link

Bug description

Both generated scripts (build.sh and flash.sh) won't work when running template on Windows and using Dev Containers support.
The problem is that .sh files on Windows are created using CR/LF, while Linux expects only LF. Saving .sh files in Windows using LF or in Linux does the trick.

  • Would you like to work on a fix? [y/n]
    I'd say yes, but have almost no experience with Rush so far. I might try but don't count on me too much.

To Reproduce

Run the template on Windows, use Dev Containers.
Open the project in VS Code within container, try running build or build & flash.

Expected behavior

Both build and build & flash tasks should run.

Screenshots

Environment

  • OS: Windows 10/WSL2

Additional context

@SergioGasquez
Copy link
Member

Thanks for reporting the issue, just did a quick test and using sed -i 's/\r$//' scripts/build.sh seems to solve the issue in WIndows.

@tomassebestik tomassebestik removed the bug label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants