Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Skandha shouldn't remove UserOp from local mempool in case of on-chain revert. #124

Closed
ch4r10t33r opened this issue Nov 30, 2023 · 0 comments · Fixed by #130
Closed

BUG: Skandha shouldn't remove UserOp from local mempool in case of on-chain revert. #124

ch4r10t33r opened this issue Nov 30, 2023 · 0 comments · Fixed by #130
Assignees
@0xSulpiride
Labels
bug Something isn't working

Comments

@ch4r10t33r
Copy link
Member

Describe the bug

Skandha presently doesn't reprocess a UserOp in case of an on-chain failure. This is incorrect.

Expected behavior

The submitted UserOp should be deleted from the local mempool only after listening to a successful UserOpEvent from the EntryPointContract.

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Skandha version or commit hash

v1.0.24-alpha
@ch4r10t33r ch4r10t33r added the bug Something isn't working label Nov 30, 2023
@ch4r10t33r ch4r10t33r changed the title BUG: Skandha shouldn't UserOp from local mempool in case of on-chain revert. BUG: Skandha shouldn't remove UserOp from local mempool in case of on-chain revert. Dec 4, 2023
@ch4r10t33r ch4r10t33r linked a pull request Dec 6, 2023 that will close this issue
feat: flashbots #130
Merged
8 tasks
@0xSulpiride 0xSulpiride mentioned this issue Dec 7, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xSulpiride 0xSulpiride

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: flashbots etherspot/skandha
2 participants
@ch4r10t33r @0xSulpiride