Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test in ci #9

Closed
joaothallis opened this issue May 9, 2020 · 2 comments
Closed

Failing test in ci #9

joaothallis opened this issue May 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@joaothallis
Copy link
Collaborator

joaothallis commented May 9, 2020 •
edited
Loading

Without modification of develop branch, one test is failing in ci.

Build: https://travis-ci.org/github/evadne/gen_magic/jobs/684948387
@joaothallis joaothallis added the bug Something isn't working label May 9, 2020
@hrefhref
Copy link
Contributor

The current code uses magic_error which apparently can return very random text or just no text. My PR #13 fixes this by using magic_errno.

@hrefhref hrefhref mentioned this issue May 14, 2020
Closed
@evadne
Copy link
Owner

evadne commented Mar 15, 2021

I think this is resolved on the develop branch but if not please reopen. Thanks!

@evadne evadne closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evadne @hrefhref @joaothallis