Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft for engine and activerecord #15

Open
jadetr opened this issue Apr 28, 2014 · 2 comments
Open

First draft for engine and activerecord #15

jadetr opened this issue Apr 28, 2014 · 2 comments

Comments

@jadetr
Copy link

jadetr commented Apr 28, 2014

Hello,

I've forked the repo and added "engine and activerecord" support to easily save results from webhooks into the DB. I'd like to get a feedback on the work done so far.

Is there interest to merge this fork into the master branch?
If yes, is there other features that should be added/removed.
I'd like to have feedback to fix things before submitting my work.

Regards,

Jade

https://github.com/jadetr/mandrill-rails.git

right now to save webhooks for open and click events, I just have to mount the engine:
route.rb
mount Mandrill::Engine => "/mandrill", :as => "mandrill"

import and run migration:
rake railties:install:migrations
rake db:migrate

@tardate
Copy link
Member

tardate commented Apr 29, 2014

@jadetr great, thanks for sharing the work! So far I've been using some variations on the same pattern but I hadn't got around to formalising it. I haven't looked at your fork yet, but I'm expecting it to be very similar ... with the exception that I'm using MongoDB in many cases, so to roll this in we'd need to make sure it is flexible enough to allow capabilities to be enabled only as required.

I'll take a look at your fork and make some suggestions OK?

@jadetr
Copy link
Author

jadetr commented Apr 29, 2014

@tardate absolutely, look at it and give me your suggestions.
Do you have a gem to recommends that play nicely with ActiveRecord and MongoDB? I'd like to look at the way they support both backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants