Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You must define a type for Eversign\\Business::$businessId #86

Open
Akecel opened this issue May 30, 2024 · 0 comments
Open

You must define a type for Eversign\\Business::$businessId #86

Akecel opened this issue May 30, 2024 · 0 comments

Comments

@Akecel
Copy link

Akecel commented May 30, 2024

Describe the bug

Hello !

It seems that the new version of the jms/serializer dependency breaks the Eversign SDK.

As can be seen in the jms/serializer 3.30.0 release, doctrine/annotation is now optional and this seems to cause problems that prevent your package from working properly. Using the client causes this error :

You must define a type for Eversign\\Business::$businessId

This isn't the first time these two packages and their updates have caused a problem and prevented the Eversign SDK from working properly : #74 #75 #81

So I think it would be safer to part with your use of doctrine/annotation now or find a way to make it work without problem at every update...

I haven't managed to figure out exactly what's causing the bug here, but I can confirm that it does come from version 3.30.0 of jms/serializer. I was able to get round this problem temporarily by fixing the versions on my side :

 "eversign/eversign-php-sdk": "1.27.0",
 "jms/serializer": "3.29.1",
 "doctrine/annotations": "1.14.3",

It is becoming urgent to deal with all problem of doctrine/annotation that this package can continue to be used without blocking users.

To Reproduce

Use the EverSign client with a fresh composer update

  • eversign-php-sdk : 1.27.0
  • jms/serializer : 3.30.0
$client = new Client(
       config('services.eversign.key'),
      config('services.eversign.id')
);

Error 500 ➡️ You must define a type for Eversign\\Business::$businessId

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant