From 981dea304e5811d69bb343067d8c394eb01dfbfc Mon Sep 17 00:00:00 2001 From: "David J. M. Karlsen" Date: Wed, 7 Apr 2021 01:05:54 +0200 Subject: [PATCH] MinTtl should be optional. Fixes #226 --- api/v1alpha1/githubactionrunner_types.go | 1 + config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/api/v1alpha1/githubactionrunner_types.go b/api/v1alpha1/githubactionrunner_types.go index e8895835..1d4a98d4 100644 --- a/api/v1alpha1/githubactionrunner_types.go +++ b/api/v1alpha1/githubactionrunner_types.go @@ -32,6 +32,7 @@ type GithubActionRunnerSpec struct { MaxRunners int `json:"maxRunners"` // Minimum time to live for a runner. This can avoid trashing by keeping pods around longer than required by jobs, keeping caches hot. + // +kubebuilder:validation:Optional // +kubebuilder:default="0m" // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Minimum time to live" MinTTL metav1.Duration `json:"minTtl"` diff --git a/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml b/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml index a0b7fbf6..33dda109 100644 --- a/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml +++ b/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml @@ -3826,7 +3826,6 @@ spec: required: - maxRunners - minRunners - - minTtl - organization - podTemplateSpec type: object