Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: atomic decoding #2

Open
mkcms opened this issue Jun 6, 2020 · 0 comments
Open

Feature request: atomic decoding #2

mkcms opened this issue Jun 6, 2020 · 0 comments

Comments

@mkcms
Copy link
Contributor

mkcms commented Jun 6, 2020

When something is wrong in the middle of decoding a packet, you get an error, and decoding is aborted and you don't get half of the decoded packet.
But, templates and options in this packet which were valid and added before the error was seen are not removed. This is bad behavior IMO, I think we should only add all templates/options after decoding is finished, and everything is known to be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant