Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show URL of currently selected bookmark #16

Open
exhuma opened this issue Oct 11, 2022 · 8 comments · May be fixed by #18
Open

Show URL of currently selected bookmark #16

exhuma opened this issue Oct 11, 2022 · 8 comments · May be fixed by #18
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@exhuma
Copy link
Owner

exhuma commented Oct 11, 2022

The URL of the currently selected should be made visible in the UI

When navigating with the keyboard, and when titles of bookmarks are ambiguous, seeing the URL helps identifying the proper bookmark.

A proposed solution could be a small-text "footer" of the extension popup. Similar to the way browsers show URLs when hovering over a link

@exhuma exhuma added enhancement New feature or request good first issue Good for newcomers labels Oct 11, 2022
@LukasJanik55
Copy link

Hello, could i work on this issue?

@exhuma
Copy link
Owner Author

exhuma commented Oct 11, 2022

Absolutely. Not sure why you got a downvote for this 😄

If you need any help to set up the development environment, let me know. I can guide you through it if necessary.

If you use VS-Code, I recommend using the "remote-development" extension which makes this pretty straight forward. When you open the project with that extension installed, it will give you a popup asking you to "reopen in container".

Accepting that prompt will give you a container in which you can simply type npm run serve to get a simple dev-environment that you can open directly in the browser.

If you need any help, let me know.

@LukasJanik55
Copy link

Thanks for a fast response, could you also assign the issue to me? I'll contact you if i have any problems with setting up the project 👍

@LukasJanik55
Copy link

Hello, sorry for starting so late, i had some trouble setting up docker, but i've finally managed to build and run the application so i'll work on the issue today / throughout the weekend.

@LukasJanik55
Copy link

how does this look to you?

image

@exhuma
Copy link
Owner Author

exhuma commented Oct 29, 2022

Hi, first of all, I'm glad you got it up and running and managed to do some development on the project.

As you are the first sending in a PR I'm curious to hear your thoughts on my current documentaion and development setup. I want the process to be easy and painless. I'd really love to hear about any improvments you see.

No, concerning the changes you've made. I like it!

My initial thought was to put it into the lower left, like browsers do it when hovering over links. Something like this:

image

The reason for this is mouse-interaction. The link should also be visible when the mouse hovers over the link. When the link is inserted below the title, everything below that item will "shift down". I don't know how that will feel when using the mouse. I'm worried that it will create a "jittery/jumpy" user-interface.

Have you tested this? How does it feel to you?

@LukasJanik55
Copy link

Hello, sorry for the late reply again, i had a busy week.

Documentation seems fine to me. I understand the projects aim and its easy / simple to use.

I've had two issues with the development side.

Firstly, i couldn't figure out, how to build / start the application, because your documentation says to use "Remote Containers" extension, but i couldn't find it. I've downloaded "Dev Containers" extension, that could do the opening the folder as a container, but using the command palette was creating an "empty" container, so the solution was to open the extension and click on the "Open Folder in Container..." button.

The second problem was that while running the local dev server, i missed in the documentation that i have to go to /demo/index.html page. So i was stuck figuring out if my container was running correctly.

Currently, i've figured out how to show the link in the "footer" of the extension, but i have some minor issues with the CSS spacing that it sometimes doesn't show correctly, so i need to fix that and it should be done. Showing the link works on @mouseover and @focus events, so it seems to be working both with mouse and keyboard controls.

image

@exhuma
Copy link
Owner Author

exhuma commented Nov 6, 2022

First, thanks for the feedback. I'll update the contribution guide with your recommendations.

The change looks pretty good to me now 😃

If you want, you can already open a pull-request with your changes so I can review the code.

@LukasJanik55 LukasJanik55 linked a pull request Nov 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants