feat: add language picker #1695
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't add the picker in the mobile, but I'll add it and remove the language part if you folks want. And I also like the picker. 😄 |
|
@cengizcmataraci |
|
Hello, sorry about the delay. Could you review again, please? I added the language picker for mobile. I tested for various devices in browser dev tools. @bjohansebas @carlosstenzel |
There was a problem hiding this comment.
Thank you for working on this @cengizcmataraci, it really looks great
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| } | ||
|
|
||
| #language-picker-menu #navmenu>li:first-child { | ||
| display: flex !important; |
There was a problem hiding this comment.
We try not to use !important, please find a way to remove it.
There was a problem hiding this comment.
Sure, I will look at it.
|
On mobile, I think it would be better to handle it the same way as on desktop, meaning the menu doesn't take up the full width, similar to how Node.js does it
And maybe always keep the icon instead of showing the language name |
Are you referring to the desktop version? Because we don’t display the language name in the mobile picker. And do we really think the Node.js website offers a better UX for the mobile picker? I find it a bit confusing. In our design, the user opens the picker solely to change the language, and once that’s done, it closes automatically. @bjohansebas |
|
I'm not an expert in UX/UI to determine if Node.js has the best mobile user experience, it was just a suggestion, so I'm okay with leaving it as it is, which I also think is great. |
|
In my analysis, I believe it is good for this first version.
|
Adding language picker to header
closes #1687