Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max width and height setting #1475

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Add max width and height setting #1475

merged 13 commits into from
Nov 25, 2024

Conversation

LiliaDoe
Copy link
Contributor

@LiliaDoe LiliaDoe commented Nov 24, 2024 •
edited
Loading

@gitguardian GitGuardian
Copy link

gitguardian bot commented Nov 24, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1943764 Triggered Generic High Entropy Secret 32c9f68 plugins/naver.js View secret
1943764 Triggered Generic High Entropy Secret c37f111 plugins/naver.js View secret
1943765 Triggered Generic High Entropy Secret 32c9f68 plugins/naver.js View secret
1943765 Triggered Generic High Entropy Secret c37f111 plugins/naver.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@LiliaDoe LiliaDoe force-pushed the Updated-max-width-and-height-setting-branch branch from c1150f3 to c37f111 Compare November 24, 2024 22:20
@LiliaDoe
Copy link
Contributor Author

LiliaDoe commented Nov 24, 2024 •
edited
Loading

Tried to fix my git repository and things just got worse. Either way, it works. It just brings up secrets in naver.js again

@LiliaDoe LiliaDoe marked this pull request as ready for review November 24, 2024 22:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@extesy extesy merged commit 3ba4c87 into extesy:master Nov 25, 2024
2 checks passed
@extesy
Copy link
Owner

extesy commented Nov 25, 2024

LGTM. I didn't see any secrets in naver.js though.

@LiliaDoe LiliaDoe deleted the Updated-max-width-and-height-setting-branch branch November 25, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying max size for the preview
3 participants
@LiliaDoe @extesy @nymver