Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoverZoom+ doesn't respect the show picture delay. #1388

Open
ChromiaCat opened this issue Aug 11, 2024 · 1 comment
Open

HoverZoom+ doesn't respect the show picture delay. #1388

ChromiaCat opened this issue Aug 11, 2024 · 1 comment
Labels

Comments

@ChromiaCat
Copy link

ATTENTION! If you don't follow this template then your issue will be immediately closed.

Description of the problem

Sometimes HoverZoom+ will show a picture immediately upon hover instead of respecting the delay set.

Url of the page where the problem occurs (not the image url)

deviantart.com

Steps to reproduce the problem (include image url here)

  1. Go to deviantart.com
  2. Start scrolling at the homepage or on someone's gallery without moving the cursor.
  3. Stop scrolling & move the cursor to position it above an artwork post and HoverZoom+ won't respect the delay set before loading an image.

OS version, extension version

Win10 19045.2965 HoverZoom+ 1.0.218

@extesy extesy added the bug label Aug 15, 2024
@Ashden
Copy link

Ashden commented Jan 1, 2025

Did a bit of digging into this. Not really familiar with the entire codebase yet, but as far as I can trace, the issue stems from this:

const delay = actionKeyDown || explicitCall ? 0 : (isVideoLink(srcDetails.url) ? options.displayDelayVideo : options.displayDelay);

Most likely is a complication of the scrolling while not moving the mouse. Did a quick test of removing the 'explicitCall' condition and then the delay is respected (in the original form, explicitCall causes the delay to be zero in some instances of scrolling, making the picture appear immediately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants