Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a typo in deployment.mdx #5897

Closed
wants to merge 1 commit into from

Conversation

fishmandev
Copy link
Contributor

Motivation

Fix a typo

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Not needed

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 7, 2021
@netlify
Copy link

netlify bot commented Nov 7, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 43729a8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6187724f682f4f0008684eed

😎 Browse the preview: https://deploy-preview-5897--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5897--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the main doc, not just the beta.8 versioned one.

@fishmandev
Copy link
Contributor Author

Done it

@Josh-Cena
Copy link
Collaborator

Actually I'll fix this as part of #4409🤦‍♂️ Sorry but I'll close this and move to something more substantial. Thanks for the contribution still!

@Josh-Cena Josh-Cena closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants