Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Node-API support to Static Hermes #1610

Open
neildhar opened this issue Feb 7, 2025 · 0 comments
Open

Adding Node-API support to Static Hermes #1610

neildhar opened this issue Feb 7, 2025 · 0 comments

Comments

@neildhar
Copy link
Contributor

neildhar commented Feb 7, 2025 •
edited by tmikov
Loading

There is an existing PR to add Node-API to Hermes (#1377). In order to add support Static Hermes, we need to do a few things in addition to what is currently done in the PR:

  1. Pull the latest version of the Node-API implementation from https://github.com/microsoft/hermes-windows
  2. Add the tests for the Node-API implementation from that repo
  3. Put the implementation in a separate directory in the API directory
  4. Add a separate CMake target for the Node-API implementation
@tmikov tmikov changed the title Adding Node-API support Adding Node-API support to Static Hermes Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neildhar