From 42400f4eba02e39eef0a22a84350e36e2653a59b Mon Sep 17 00:00:00 2001 From: Yannick Loriot Date: Mon, 3 Feb 2025 08:52:25 -0800 Subject: [PATCH] Fix compiler issue when DEBUG is not set Summary: ## Problem In some cases, the `DEBUG` flag can be unset, and this creates build issues: ``` third-party/react-native-macos/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm:42:5: error: 'DEBUG' is not defined, evaluates to 0 [-Werror,-Wundef] 42 | #if DEBUG | ^ ``` ## Diff Add `defined(DEBUG)` checks to unblock builds and better robustness. Differential Revision: D69049701 --- packages/react-native/React/Base/RCTAssert.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/React/Base/RCTAssert.h b/packages/react-native/React/Base/RCTAssert.h index 47d4409f6e2577..233b1d925fdce4 100644 --- a/packages/react-native/React/Base/RCTAssert.h +++ b/packages/react-native/React/Base/RCTAssert.h @@ -157,7 +157,7 @@ RCT_EXTERN NSString *RCTFormatStackTrace(NSArray *> /** * Convenience macro to assert which thread is currently running (DEBUG mode only) */ -#ifdef DEBUG +#ifdef defined(DEBUG) && DEBUG #define RCTAssertThread(thread, ...) \ _Pragma("clang diagnostic push") _Pragma("clang diagnostic ignored \"-Wdeprecated-declarations\"") RCTAssert( \