Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on Ubuntu #13264

Closed
vaqxai opened this issue Jan 2, 2025 · 0 comments
Closed

Build fails on Ubuntu #13264

vaqxai opened this issue Jan 2, 2025 · 0 comments

Comments

@vaqxai
Copy link
Contributor

vaqxai commented Jan 2, 2025 •
edited
Loading

Expected behavior

the static library is built correctly

Actual behavior

when building memtable/wbwi_memtable.o:

In file included from memtable/wbwi_memtable.cc:6:
./memtable/wbwi_memtable.h: In member function 'void rocksdb::WBWIMemTableIterator::UpdateKey()':
./memtable/wbwi_memtable.h:126:49: error: array subscript 0 is outside array bounds of 'std::aligned_storage<8, 4>::type [0]' [-Werror=array-bounds=]
  126 |                               std::to_string(t->second));
      |                                              ~~~^~~~~~
cc1plus: note: source object is likely at address zero
cc1plus: all warnings being treated as errors
make: *** [Makefile:2569: memtable/wbwi_memtable.o] Error 1

Steps to reproduce the behavior

  1. clone the repo
  2. install dependencies
  3. run make static_lib

This should be fixed by this commit which going by this pull but is not?

Oh, i see. Going by the commit history this was later overwritten by this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reapply fix for https://github.com/facebook/rocksdb/issues/13166 vaqxai/rocksdb
1 participant
@vaqxai