From bf0043ccdcf4f89deac744cd400b9e2e24a97c24 Mon Sep 17 00:00:00 2001 From: Chad Austin Date: Mon, 22 Aug 2022 10:05:10 -0700 Subject: [PATCH] upgrade getdeps GitHub actions to Ubuntu 20 (#516) Summary: X-link: https://github.com/facebook/fbthrift/pull/516 X-link: https://github.com/facebook/watchman/pull/1050 X-link: https://github.com/facebook/proxygen/pull/426 X-link: https://github.com/facebook/folly/pull/1842 X-link: https://github.com/facebook/fboss/pull/117 Sadly, even though Ubuntu 18.04 is still in LTS, GitHub is deprecating its runner image. Migrate the generated GitHub Actions to 20.04. https://github.com/actions/runner-images/issues/6002 https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ Reviewed By: fanzeyi Differential Revision: D38877286 fbshipit-source-id: 85f3324d6666eacb190a43985585b438de69d545 --- .github/workflows/getdeps_linux.yml | 2 +- build/fbcode_builder/getdeps.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/getdeps_linux.yml b/.github/workflows/getdeps_linux.yml index eb72e15e5..f7a1a3f66 100644 --- a/.github/workflows/getdeps_linux.yml +++ b/.github/workflows/getdeps_linux.yml @@ -12,7 +12,7 @@ on: jobs: build: - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - name: Fetch ninja diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index 369285bb8..8c270c0bc 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -1115,7 +1115,7 @@ def setup_project_cmd_parser(self, parser): help="Allow CI to fire on all branches - Handy for testing", ) parser.add_argument( - "--ubuntu-version", default="18.04", help="Version of Ubuntu to use" + "--ubuntu-version", default="20.04", help="Version of Ubuntu to use" ) parser.add_argument( "--main-branch",