Compilation failure on dwio/dwrf/common/Common.h

[rui-mo]

Problem description

We notice a compilation failure on 'dwio/dwrf/common/Common.h' during the compiling process of the experimental fuzzer test.

https://github.com/facebookincubator/velox/actions/runs/13331383842/job/37236086435?pr=9559

System information

Velox System Info v0.0.2
Commit: 9c9c7d9
CMake Version: 3.31.5
System: Darwin-23.6.0
Arch: arm64
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 16.0.0.16000026
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 16.0.0.16000026
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

CMake log

/home/runner/work/velox/velox/velox/velox/common/memory/tests/SharedArbitratorTest.cpp
In file included from /home/runner/work/velox/velox/velox/./velox/dwio/dwrf/common/Common.h:25,
                 from /home/runner/work/velox/velox/velox/./velox/dwio/dwrf/common/Config.h:23,
                 from /home/runner/work/velox/velox/velox/./velox/exec/tests/utils/HiveConnectorTestBase.h:22,
                 from /home/runner/work/velox/velox/velox/velox/common/memory/tests/SharedArbitratorTest.cpp:39:
/home/runner/work/velox/velox/velox/./velox/dwio/common/StreamIdentifier.h:40:16: error: ‘virtual bool facebook::velox::dwio::common::StreamIdentifier::operator==(const facebook::velox::dwio::common::StreamIdentifier&) const’ was hidden [-Werror=overloaded-virtual=]
   40 |   virtual bool operator==(const StreamIdentifier& other) const {
      |                ^~~~~~~~
/home/runner/work/velox/velox/velox/./velox/dwio/dwrf/common/Common.h:203:8: note:   by ‘bool facebook::velox::dwrf::DwrfStreamIdentifier::operator==(const facebook::velox::dwrf::DwrfStreamIdentifier&) const’
  203 |   bool operator==(const DwrfStreamIdentifier& other) const {
      |        ^~~~~~~~

[Yuhta]

Can we remove virtual from operator==, hash and getId, then remove operator== and hash in DwrfStreamIdentifier? It seems just not used.