Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: TableScanReplayerTest fails with "Memory pool TableScan_replayer_0 already exists" #12360

Closed
majetideepak opened this issue Feb 17, 2025 · 1 comment
Closed

CI: TableScanReplayerTest fails with "Memory pool TableScan_replayer_0 already exists" #12360

majetideepak opened this issue Feb 17, 2025 · 1 comment
Assignees
@duanmeng
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@majetideepak
Copy link
Collaborator

Bug description

participants_.count(pool->name()) == 0 (1 vs. 0) Memory pool TableScan_replayer_0 already exists, Source: RUNTIME, ErrorCode: INVALID_STATE
unknown file: Failure

https://github.com/facebookincubator/velox/actions/runs/13345770538/job/37276039027

System information

https://github.com/facebookincubator/velox/actions/runs/13345770538/job/37276039027

Relevant logs


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @majetideepak
majetideepak




            added
      

  bug

  Something isn't working

      

  triage

  Newly created issue that needs attention.

  labels


      Feb 17, 2025

    

  



    







      

  
      



  

  @majetideepak





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  Author


  


  

    

  





      


        


  
    

      
          
@duanmeng We should likely include the TableScan NodeId when creating the pool.

https://github.com/facebookincubator/velox/blob/main/velox/tool/trace/OperatorReplayerBase.cpp

Right now, this error can occur if both the TableScanReplayTests run at the same time.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @duanmeng
duanmeng



    mentioned this issue
    
      Feb 18, 2025
    





  


  

      
   Closed

  







  




    

    


  









  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @duanmeng
  
    duanmeng
    

      








      


  


  

    Labels
  



    

      

    bug

  Something isn't working
  

    triage

  Newly created issue that needs attention.








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      

        
          

            
    

    Development
  




              
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: Flakey memory pool already exists failure in TableScanReplayerTest

    
      duanmeng/velox
    





        
      

    

  


      

    

  
      

  

    

      2 participants
    

    

        
          @majetideepak 
        
          @duanmeng