Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for max-connections option in S3FileSystem #9436

Closed
majetideepak opened this issue Apr 10, 2024 · 1 comment
Closed

Add support for max-connections option in S3FileSystem #9436

majetideepak opened this issue Apr 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@majetideepak
Copy link
Collaborator

Description

Aws::Client::ClientConfiguration::maxConnections sets the maximum number of connections to an S3 server.
The default value is 25. We must add an option to set this.
Presto Java added this option here https://prestodb.io/docs/current/release/release-0.75.html and sets the default to 500.
@majetideepak majetideepak added the enhancement New feature or request label Apr 10, 2024
@wills-feng wills-feng mentioned this issue Apr 12, 2024
Closed
facebook-github-bot pushed a commit that referenced this issue Apr 18, 2024
@wills-feng @facebook-github-bot
Add hive.s3.connect-timeout, hive.s3.socket-timeout and hive.s3.max-c…
74fe2ba 
…onnections configs (#9472)

Summary:
hive.s3.connect-timeout allows configuring the socket connection timeout.
hive.s3.socket-timeout allows configuring the socket read timeout.
hive.s3.max-connections allows configuring the max concurrent tcp connections for a single http client.

Resolves #2941, #9436

Pull Request resolved: #9472

Reviewed By: pedroerp

Differential Revision: D56264306

Pulled By: Yuhta

fbshipit-source-id: 8882a3d4b3e1da943222b3e2bc6cd155cbceddf6
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this issue Jun 7, 2024
@wills-feng @Joe-Abraham
Add hive.s3.connect-timeout, hive.s3.socket-timeout and hive.s3.max-c…
079a25b 
…onnections configs (facebookincubator#9472)

Summary:
hive.s3.connect-timeout allows configuring the socket connection timeout.
hive.s3.socket-timeout allows configuring the socket read timeout.
hive.s3.max-connections allows configuring the max concurrent tcp connections for a single http client.

Resolves facebookincubator#2941, facebookincubator#9436

Pull Request resolved: facebookincubator#9472

Reviewed By: pedroerp

Differential Revision: D56264306

Pulled By: Yuhta

fbshipit-source-id: 8882a3d4b3e1da943222b3e2bc6cd155cbceddf6
@majetideepak
Copy link
Collaborator Author

This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majetideepak