Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues in master #30

Open
mhmdshorafa opened this issue Jan 16, 2018 · 4 comments
Open

issues in master #30

mhmdshorafa opened this issue Jan 16, 2018 · 4 comments

Comments

@mhmdshorafa
Copy link
Contributor

mhmdshorafa commented Jan 16, 2018

"dependencies": {

your package.json file contains unused dependencies and some of it should be in developer dependencies

@mhmdshorafa
Copy link
Contributor Author

mhmdshorafa commented Jan 16, 2018

const sql = fs.readFileSync(path.join(__dirname, '/build.sql'));

asynchronous code is an advantage for node ,, try to avoid make restrictions on the asynchronous code unless it was necessary
you can use some thing like that

fs.readFile(path.join(__dirname, '/build.sql'), (err, sql) => {
  connect.query(sql, (err, res) => {
    if (err) {
      console.log(err);
    } else {
      console.log(res);
    }
  });
});

@mhmdshorafa
Copy link
Contributor Author

console.log(err);

try to take actions instead of console.log();

@mhmdshorafa
Copy link
Contributor Author

mhmdshorafa commented Jan 16, 2018

here is the issues with the code inside the master:

  • console.log(`the server work on port ${app.get('port')}`);

    if we have a good reason for breaking eslint rules ,, we can disable the line using // eslint-disable-line

@mhmdshorafa mhmdshorafa changed the title unused module and developer dependencies inside dependencies issues in master Jan 16, 2018
ismail2009 added a commit that referenced this issue Jan 16, 2018
ismail2009 added a commit that referenced this issue Jan 16, 2018
@ismail2009
Copy link
Collaborator

@mhmdshorafa it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants