Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Make it clear(er) that Scrubcsv favors snake_case over CamelCase in header #20

Open
ngirard opened this issue Mar 21, 2021 · 0 comments

Comments

@ngirard
Copy link

ngirard commented Mar 21, 2021

It seems like Scrubcsv favors snake_case in the header, since A B is transformed into a_b.
I'm fine with that, although it's not part of RFC 4180.
I'd suggest making it clear(er) by

  • mentioning it in the README;
  • adding a dedicated test in the tests.rs file, similar to the one below;
  • making it optional with a dedicated command-line option;
  • being more consistent by replacing CamelCase with camel_case

My test:

echo "Aa,A B,CamelCase"|scrubcsv --clean-column-names
aa,a_b,camelcase
1 rows (0 bad) in 0.00 seconds, 214.33 KiB/sec

(I'd expect to get aa,a_b,camel_case instead)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant