Skip to content
This repository has been archived by the owner on Aug 13, 2018. It is now read-only.

Falsy JSON values appear as quoted empty strings #68

Open
tdhsmith opened this issue Jan 5, 2017 · 3 comments
Open

Falsy JSON values appear as quoted empty strings #68

tdhsmith opened this issue Jan 5, 2017 · 3 comments

Comments

@tdhsmith
Copy link

tdhsmith commented Jan 5, 2017

Expanding JSON payloads or inspecting them in the JSON tab seems to wreck JS falsy values (notably 0 and null) and display them as quoted empty strings ("").

For example, observe how the objectId and alert properties change as the tree is expanded:
screen shot 2017-01-05 at 2 10 40 pm
screen shot 2017-01-05 at 2 10 49 pm
screen shot 2017-01-05 at 2 10 57 pm
Demonstrated in WebSocket Monitor 0.6.4 on FF dev edition 52.0a2.

Is all the TreeView behavior coming from the Firebug SDK? I don't know enough about extensions or React to trace the functionality very quickly here...

@eliihen
Copy link
Member

eliihen commented Jan 5, 2017

Hey, good catch. I can reproduce on http://janodvarko.cz/test/websockets/ by sending {"a":0}

Yep, the TreeView behavior is from the Firebug SDK, so you should open a bug over there. When it is fixed in the SDK we can bump the version of the version in Websocket Monitor

@eliihen
Copy link
Member

eliihen commented Jan 5, 2017

Wait. It turns out this was fixed a while ago firebug/firebug.sdk#20, but no new version was released! I'll make an issue to see if we can get it bumped

@tdhsmith
Copy link
Author

tdhsmith commented Jan 5, 2017

Awesome thanks for the fast response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants